Skip to content
This repository was archived by the owner on Sep 30, 2022. It is now read-only.

Conversation

@mike-dubman
Copy link
Member

No description provided.

@mike-dubman mike-dubman changed the title Add-two-new-mca-variables Add-two-new-mca-variables, fix opal_help failure Oct 6, 2014
@jsquyres jsquyres added this to the v1.8.4 milestone Oct 6, 2014
@mike-dubman
Copy link
Member Author

other changes are fixes for the following situation:

  • All PEs should have same VA for memheap
  • before fix, some sshmem allocators could end-up with having different VAs for memheap across all PEs.
  • we fixed all places in sshmem allocators (hugepages, verbs) which could lead to that bug by introducing two new MCA variables. This variables can be on/off hugepages and verbs(shared_mr) services dynamically if requested VA cannot be attached and next or other allocator will be used instead.
  • Please let this change as-is, we will try harder to break PRs into smaller pieces for next ones.
    Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really level 3? By https://github.com/open-mpi/ompi/wiki/MCAParamLevels, I'd think that this was level 4 or 5.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed to level4

@mike-dubman mike-dubman force-pushed the topic/oshmem_add_two_new_mca_variables branch from 19486a5 to 414bee5 Compare October 12, 2014 12:47
@mike-dubman
Copy link
Member Author

  • Will open separate issue to s/#ifdef MACRO/#if MACRO/g for @nkogteva
  • Will re-integrate into "master" once no more comments observed.

@rhc54
Copy link

rhc54 commented Oct 23, 2014

What is the status of this PR? I see last comments indicating further work required, and that these changes may not yet be in the trunk. True?

@mike-dubman
Copy link
Member Author

@rhc54 - all comments were addressed, PR is ready to go.

@rhc54
Copy link

rhc54 commented Oct 23, 2014

Where is the master hash?

mike-dubman added a commit to open-mpi/ompi that referenced this pull request Oct 24, 2014
@mike-dubman
Copy link
Member Author

open-mpi/ompi@5ce2f10

@mike-dubman
Copy link
Member Author

attempt 2:
open-mpi/ompi@5ce2f10

@rhc54
Copy link

rhc54 commented Oct 24, 2014

There are conflicts in this patch - please resolve them.

Added use_hp flag in sshmem/sysv variable to control huge page usage;
Added shared_mr sshmem/verbs;
Both paraemetes are set in auto.
Fix help messages

fixed by Igor, reviewed by @miked-mellanox and @alex-mikheev
(cherry picked from commit d82dc7f)
@mike-dubman mike-dubman force-pushed the topic/oshmem_add_two_new_mca_variables branch from 414bee5 to 38ae556 Compare October 25, 2014 17:33
@mike-dubman
Copy link
Member Author

@rhc54 - done. Thanks.

rhc54 pushed a commit that referenced this pull request Oct 28, 2014
…a_variables

Add-two-new-mca-variables, fix opal_help failure
@rhc54 rhc54 merged commit da1cdd7 into open-mpi:v1.8 Oct 28, 2014
mike-dubman added a commit to mike-dubman/ompi-release that referenced this pull request Oct 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants