This repository was archived by the owner on Sep 30, 2022. It is now read-only.
pmix: fix finalize ordering issue #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't destroy the event base before destroying all objects that contain events (and call event_del(), which uses the event base on which event is enqueued). This matches the ordering in the Open MPI master. Fixes open-mpi/ompi#1117
|
As I said on the other ticket you opened on this, it appears to be simply a case of 2.x not having all the pmix updates yet. I wouldn't piecemeal it - the plan is to provide a complete update once pmix 1.1.0 is released. |
|
Test PASSed. |
Member
Author
|
Per discussion on the 2015-11-10, @rhc54 says the fix is fine. The ultimate plan is to re-sync pmix in both master and v2.x when pmix 1.1 is released (at some point in the near future). So let's get this fix in. |
jsquyres
added a commit
that referenced
this pull request
Nov 10, 2015
…g-fix pmix: fix finalize ordering issue
alinask
pushed a commit
to alinask/ompi-release
that referenced
this pull request
Dec 10, 2015
Standardize verbosity levels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't destroy the event base before destroying all objects that contain events (and call event_del(), which uses the event base on which event is enqueued).
This matches the ordering in the Open MPI master.
@rhc54 How do you want to handle this? Do you want piecemeal PMIx bug fixes like this, or do you want to do a re-sync of PMIx from OMPI master (or PMIx master?)?
This issue was initially found by valgrind on #747 (comment), and then had its own issue opened in open-mpi/ompi#1117.
@rhc54 Please review.