This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Comm split fixes #815
Merged
Comm split fixes #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit open-mpi/ompi@f279474)
Previous commit f279474 reverts Nathans changes. However it turns out that I was unable to trace his logic until I started investigation of icsplit hang. Bug was triggered when splitting Intercom was giving a group where on side of the communicator was empty (icsplit, intercom create open-mpi#2). in this case remote_size == 0 and there is no way to distinguish between inter- and intra-communicator. Conclusion: We do need to distinguish between intra- and inter-communicators. So we should use ompi_mpi_group_null.group. (cherry picked from commit open-mpi/ompi@7690f40)
Contributor
Author
|
I have verified this PR and compared results before and after PR for 2.x. |
|
Test PASSed. |
Member
|
👍 |
artpol84
added a commit
to artpol84/ompi-release
that referenced
this pull request
Feb 10, 2016
* open-mpi#815 * open-mpi#819 * open-mpi#832 * open-mpi#833 * open-mpi#852 * open-mpi#868 * open-mpi#879 * open-mpi#887 * open-mpi#888 * open-mpi#889 (related to the commit open-mpi/ompi@2abb297)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes inter-communicator split logic. Commits are cherry-picked from:
:bot:assign: @hjelmn
:bot:milestone:v2.0.0
:bot🏷️bug
:bot🏷️blocker