This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Move powerpc atomics fixes and improvements to v2.x #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
:bot🏷️bug |
This commit adds implementations of opal_atomic_ll_32/64 and opal_atomic_sc_32/64. These atomics can be used to implement more efficient lifo/fifo operations on supported platforms. The only supported platform with this commit is powerpc/power. This commit also adds an implementation of opal_atomic_swap_32/64 for powerpc. Tested with Power8. (cherry picked from open-mpi/ompi@6a19a10) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
These instructions allow a more efficient implementation of the opal_fifo_pop_atomic function. (cherry picked from open-mpi/ompi@2a7e191) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
This commit adds implementations for opal_atomic_lifo_pop and opal_atomic_lifo_push that make use of the load-linked and store-conditional instruction. These instruction allow for a more efficient implementation on supported platforms. (cherry picked from open-mpi/ompi@209a7a0) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
Test PASSed. |
Member
Author
|
bot:assign: @bosilca |
|
Test PASSed. |
Member
|
👍 |
Member
|
@hppritcha Good to go |
hppritcha
added a commit
that referenced
this pull request
Dec 21, 2015
Move powerpc atomics fixes and improvements to v2.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been in master for quite a while. I missed opening a PR for v2.x. Current v2.x branch fails the opal_fifo tests, without these fixes. See open-mpi/ompi#720 for details