This repository was archived by the owner on Sep 30, 2022. It is now read-only.
Topic/v2.x/sentinel fixes #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSB is now automatically cleared when right shifting Thanks George for pointing this (cherry picked from commit open-mpi/ompi@030a5f2)
converting an opal_process_name_t means the loss of one bit, it was decided to restrict the local job id to 15 bits, so the useful information of an opal_process_name_t can fit in 63 bits. (cherry picked from commit open-mpi/ompi@b55b9e6)
since a sentinel is only made from the current job, only store the first 31 bits of the vpid into the sentinel. (cherry picked from commit open-mpi/ompi@96310f4)
|
Test PASSed. |
Contributor
Author
|
:bot:assign: @hjelmn |
Member
|
👍 |
Member
|
@hjelmn indicates that he is going to add one minor cleanup after this PR is merged (on both master and here). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.