This repository was archived by the owner on Sep 30, 2022. It is now read-only.
v2.0.0: cxx: "rank" is now a function in C++11 #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "myrank" instead (I tried using ::rank, but had varied success... so I just renamed the variable). (cherry picked from commit open-mpi/ompi@89d0a03)
jsquyres
changed the title
|
Test PASSed. |
Contributor
|
:bot🏷️pushed-back |
Member
Author
|
About open-mpi/ompi@e5d6b97 -- now that we require a C99 compiler, do we really need |
Contributor
Member
|
No, 128-bit integers are not yet standard so we still need opal_stdint.h for 128-bit. |
GCC 6 and later should ignore -Wpedantic instead of -pedantic (cherry picked from commit open-mpi/ompi@e5d6b97)
Member
Author
|
@ggouaillardet This PR now includes the GCC pragma fix. |
Contributor
|
👍 |
Member
Author
|
@hppritcha When CI finishes, this is good to go |
|
Test PASSed. |
hppritcha
added a commit
that referenced
this pull request
Mar 1, 2016
…shark v2.0.0: cxx: "rank" is now a function in C++11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "myrank" instead (I tried using ::rank, but had varied success... so I just renamed the variable).
(cherry picked from commit open-mpi/ompi@89d0a03)
@ggouaillardet Please review.