Skip to content

Conversation

@gpapaure
Copy link
Contributor

@gpapaure gpapaure commented Oct 9, 2015

Basic usage works again for both subarray and darray by using create_hindexed instead of create_resized
Test case cited in http://lists.mpich.org/pipermail/discuss/2015-January/003608.html still works

Basic usage works again for both subarray and darray by using create_hindexed instead of create_resized
Test case cited in http://lists.mpich.org/pipermail/discuss/2015-January/003608.html still works
@jsquyres
Copy link
Member

jsquyres commented Oct 9, 2015

@bosilca can you comment? Thanks.

@ggouaillardet
Copy link
Contributor

is this related to #965 ?

@gpapaure
Copy link
Contributor Author

I haven't seen this issue before posting the pull request, thanks.
Yes i think it is related.
As you said in your last comment create_resized doesn't produce the right datatype layout.
The solution in this patch is to use create_hindexed with only one element and the same offset than previous create_resized.
I've tested darray-alltoallw-test and darray-alltoallw-test2 and both of them works now.
The fix may apply on release branch.

@ggouaillardet
Copy link
Contributor

Thanks Guillaume,

bottom line, is MPI_Type_create_resized broken or not ?

in my test case, both mpich and ompi have the same behavior (well, ompi also issues a warning), and this is not the behavior I expected (could be a bug, or my incorrect expectation)

@jsquyres
Copy link
Member

Add @bosilca

@hjelmn
Copy link
Member

hjelmn commented Oct 16, 2015

We might want to make this issue a blocker on 2.0.0. I remember fixing an issue with subarray but didn't realize darray was also broken.

@jsquyres jsquyres added this to the Open MPI v2.0.0 milestone Oct 16, 2015
@ggouaillardet
Copy link
Contributor

IMHO #965 is the blocker and the milestone should be v1.10.1

@bosilca
Copy link
Member

bosilca commented Oct 23, 2015

Due to the emergency of the next release, after talking with Jeff we propose to get the patch proposed here in the 1.10, and create an issue for the trunk. This will give me a little bit more time to dig into the internals of the type_resize and understand what is not going as expected there.

@bosilca
Copy link
Member

bosilca commented Oct 23, 2015

The corresponding issue for the devel version is #1063.

@jsquyres
Copy link
Member

jsquyres commented Nov 2, 2015

@gpapaure Is this PR obsolete due to #1063?

@jsquyres
Copy link
Member

jsquyres commented Nov 9, 2015

I assume this issue is now closed (due to #1063 and #1072). Closing the ticket.

@jsquyres jsquyres closed this Nov 9, 2015
jsquyres pushed a commit to jsquyres/ompi that referenced this pull request Aug 23, 2016
Fix a potential race condition in which a progress matching thread co…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants