Skip to content

Cleanup compiler warnings #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Cleanup compiler warnings #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ompi/proc/proc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,6 @@ ompi_proc_t **ompi_proc_world (size_t *size)
ompi_proc_t **procs;
ompi_proc_t *proc;
size_t count = 0;
ompi_rte_cmp_bitmask_t mask;
ompi_process_name_t my_name;

/* check bozo case */
if (NULL == ompi_proc_local_proc) {
Expand All @@ -483,7 +481,7 @@ ompi_proc_t **ompi_proc_world (size_t *size)
}

/* now get/allocate all the procs in this jobid */
for (int i = 0 ; i < count ; ++i) {
for (size_t i = 0 ; i < count ; ++i) {
opal_process_name_t name = {.jobid = OMPI_CAST_RTE_NAME(&ompi_proc_local_proc->super.proc_name)->jobid,
.vpid = i};

Expand All @@ -501,7 +499,15 @@ ompi_proc_t **ompi_proc_world (size_t *size)
* count which cannot be released until ompi_proc_finalize is
* called.
*/
procs[i] = ompi_proc_for_name (name);
proc = (ompi_proc_t*)ompi_proc_for_name (name);
if (NULL == proc) {
for (size_t j=0; j < i; j++) {
OBJ_RELEASE(procs[j]);
}
free(procs);
return NULL;
}
procs[i] = proc;
}

*size = count;
Expand Down