udcm: fix bugs #1053
Merged
udcm: fix bugs #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the following bugs: - On send failure release newly allocated message. - In the destructor for udcm_message_sent_t always remove the send timeout event from the event base. Failure to do this can lead to memory corruption since the destructor may be called from an event callback. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
Author
|
@miked-mellanox This fixes a long-outstanding issue and is targeted for 1.10.1 and 2.0.0. Without this fix I see random udcm crashes when I hit the CM with lots of requests. |
Member
Author
|
I should also add that this is a quick fix for a real issue. I am rewriting the connection part of the openib btl to be truly asynchronous. This is needed to support truly passive one-sided communication. |
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
Fix the 2.0 branch segfaults on finalize - we need to be in the same …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the following bugs:
timeout event from the event base. Failure to do this can lead to
memory corruption since the destructor may be called from an event
callback.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov