v5.0.x: Fix a bunch of compiler warnings #12133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where appropriate: * Use __opal_attribute_unused__ (which tells the computer that the variable *might* be unused; it does not promise that the variable is *not* used) * Protect usage with various #if macros * Remove actually-unused variables Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit dbbf187)
Ensure that a buffer is long enough to hold the trailing \0. Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit 9aab29a)
This code is not referred to anywhere; delete it. Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit f848448)
Fix an incorrect assignment of flags: flags_derived is meant to hold flags of type mca_base_var_syn_flag_t (i.e., synonym flags), whereas flags holds flags of type mca_base_var_flag_t (i.e., regular flags). These are two different types of flags, and are not intended to be mixed. Hence, initialize the per-variable synonym flags to 0 -- do *not* initialize them to the value of the regular flags. Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit 7741cd8)
Fix compiler warnings by changing "()" to "(void)" in some function definitions. Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit a4039d4)
Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit 739d2d8)
HAVE__CLEAR_CACHE is either defined or not; it is not defined to 0 or 1. Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit cea0e24)
Don't do pointer math on (void*). Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit b7f9221)
Signed-off-by: Jeff Squyres <jeff@squyres.com> (cherry picked from commit c64fb39)
Signed-off-by: Jeff Squyres <jeff@squyres.com>
edgargabriel
approved these changes
Nov 27, 2023
bosilca
approved these changes
Nov 27, 2023
devreal
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.
This is the v5.0.x PR corresponding to main PR #12129 -- with one exception.
The last commit on this PR, "libdict/hb_tree.c: remove dead code" is not a cherry-pick from main because this warning fix is somehow not relevant to main. I.e., some prior commit must have happened on main to fix this, and then was not cherry-picked. Since it's a straight removal of code, it's a little difficult to track down where this happened and how it wasn't previously cherry-picked. So I just made this one unique fix here on the v5.0.x branch that is not a cherry pick. All the others are cherry-picked from main PR #12129.
bot:notacherrypick