Skip to content

Conversation

@ggouaillardet
Copy link
Contributor

…ort is enabled

@ggouaillardet
Copy link
Contributor Author

@bosilca could you please review this ?
I used a logic similar to unpack, so MPI_Pack_external can do the byte swapping if needed.

currently, this works only with --enable-heterogeneous.

In order to get this working without --enable-heterogeneous, I will have to always compile some code that is currently used only with heterogeneous cluster.
this will be a bit more of code which is always executed, but that is only needed for MPI_{Pack,Unpack}_external.
an other option is to duplicate some code without --enable-heterogeneous.

can you please advise ?

@ggouaillardet
Copy link
Contributor Author

@bosilca
i pushed a second commit to fix openmpi without --enable-heterogeneous
bottom line, i just had to make OPAL_CONVERTOR_COMPUTE_REMOTE_SIZE the same regardless heterogeneous support, which is a much smaller change than i anticipated.

@bosilca
Copy link
Member

bosilca commented Feb 23, 2016

@ggouaillardet I made a different patch that enables the heterogeneous mode for the OPAL datatype in all cases, and adds support for more complicated datatypes. Take a look at #1394 .

@ggouaillardet
Copy link
Contributor Author

this topic is now handled is #1394, so i am closing this PR

hjelmn pushed a commit to hjelmn/ompi that referenced this pull request Sep 13, 2016
…help-messages

v2.0.2: btl tcp fix help messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants