Topic/external support #1399
Closed
Topic/external support #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The datatype must satisfy the same constraints as for the corresponding communication function (send for pack and recv for unpack).
provide external32 support). Add a pack function allowing to provide send conversion (needed on little endian machine in order to pack in the external32 format).
Use htonl and htons to check that the packed data is indeed the correct data.
Contributor
|
Test FAILed. |
ggouaillardet
force-pushed
the
topic/external_support
branch
from
9148499 to
327eb95
Compare
Closed
ggouaillardet
force-pushed
the
topic/external_support
branch
2 times, most recently
from
0136a1c to
d2b5ce4
Compare
Contributor
Author
…D_CONVERSION && ! CONVERTOR_HOMOGENEOUS
ggouaillardet
force-pushed
the
topic/external_support
branch
from
7279472 to
39ea073
Compare
Contributor
|
Test FAILed. |
2 similar comments
Contributor
|
Test FAILed. |
Contributor
|
Test FAILed. |
…type so it can be directly used by test/datatype/external32
ggouaillardet
force-pushed
the
topic/external_support
branch
from
39ea073 to
69bd838
Compare
Contributor
Author
|
:bot:retest |
1 similar comment
Contributor
Author
|
:bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is for test only
i cannot reproduce the failure of test/datatype/external32 on centos7 nor OS X, so let's try to see what travis says about that