MTL portals4 : fix around triggered rndv operations #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this a bug? |
Member
|
Yes it is. The patch looks good, but I am waiting for the MTT results before accepting it. |
Contributor
|
Test FAILed. |
2 similar comments
Contributor
|
Test FAILed. |
Contributor
|
Test FAILed. |
Member
Author
|
strange, the compilation failed but not due to parts of this patch. |
Member
|
@francois-wellenreiter This looks good. |
tkordenbrock
added a commit
that referenced
this pull request
Mar 21, 2016
MTL portals4 : fix around triggered rndv operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @tkordenbrock, the current version of the triggered rendez-vous implementation is not able to check the size of the received data compared to the sent one and thus is unable to detect a potential MPI_ERR_TRUNCATE issue.
This fix allows this verification and fixes issues concerning a bad MPI programmation.
@regrant or @tkordenbrock could you please review this commit ?
I will retrofit it to the ompi-release repository when you accept this modification.