Skip to content

odls/base: use the full app name when using an orte fork agent #1451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2016
Merged

odls/base: use the full app name when using an orte fork agent #1451

merged 1 commit into from
Mar 14, 2016

Conversation

@ggouaillardet
Copy link
Contributor

@ggouaillardet ggouaillardet commented Mar 14, 2016

No description provided.

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Mar 14, 2016

@rhc54 could you please review this ?

if i mpirun --mca orte_fork_agent $HOME/wrapper.sh /foo/bar, then orted ends up fork&exec'ing
$HOME/wrapper.sh bar
we miss the dirname /foo and it is not even available via some environment variable.

with this commit, orted fork&exec $HOME/wrapper.sh /foo/bar which is what i expect.

this commit is very minimal, but you might want to do things differently.
for example, at this stage, app->argv[0] has already been set to the basename, it could have been the full name, and then be replaced by its basename at the very end, right before the real fork&exec

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Mar 14, 2016

:bot:retest

1 similar comment
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Mar 14, 2016

:bot:retest

@mellanox-github
Copy link

mellanox-github commented Mar 14, 2016

@rhc54
Copy link
Contributor

rhc54 commented Mar 14, 2016

Mellanox Jenkins error is unrelated: 👍

rhc54 pushed a commit that referenced this pull request Mar 14, 2016
Merge pull request #1451 from ggouaillardet/topic/orte_fork_wrapper_f…
efafd62 
…ullname

odls/base: use the full app name when using an orte fork agent
@rhc54 rhc54 merged commit efafd62 into open-mpi:master Mar 14, 2016
@ggouaillardet ggouaillardet mentioned this pull request Mar 18, 2016
Closed
bosilca pushed a commit to bosilca/ompi that referenced this pull request Oct 3, 2016
@bosilca
Revert "Merge pull request open-mpi#1451 from ggouaillardet/topic/ort…
d7cf617 
…e_fork_wrapper_fullname"

This reverts commit efafd62, reversing
changes made to a93b849.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@rhc54 rhc54

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggouaillardet @mellanox-github @rhc54