configure: re-enable built-in atomic support #1465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes an erroneous else statement from the OSX built-in atomics check. The else branch sets the built-in atomics support to BUILTIN_NO if either opal_cv_asm_builtin is not BUILTIN_NO or OSX atomics support is disabled. Signed-off-by: Nathan Hjelm <hjelmn@me.com>
|
@bosilca Whoops, I found this problem when trying to figure out why gcc 5.3 fails the opal_fifo test. I will have to check if any branches are affected. |
|
Nice catch. 👍 |
hjelmn
added a commit
that referenced
this pull request
Mar 17, 2016
configure: re-enable built-in atomic support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes an erroneous else statement from the OSX built-in
atomics check. The else branch sets the built-in atomics support to
BUILTIN_NO if either opal_cv_asm_builtin is not BUILTIN_NO or OSX
atomics support is disabled.
Signed-off-by: Nathan Hjelm hjelmn@me.com