oshmem/scoll: Fix bug in basic/barrier algorithm #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| for (i = 0; i < group->proc_count; i++) { | ||
| if (i == group->id) | ||
| if (i == oshmem_proc_group_find_id(group, group->my_pe)) |
There was a problem hiding this comment.
oshmem_proc_group_find_id() - can it be called outside loop from line 563?
it seems constant
There was a problem hiding this comment.
you are right, will update
igor-ivanov
force-pushed
the
pr/fix-scoll-basic-barrier
branch
from
87b7159 to
e690521
Compare
igor-ivanov
added a commit
that referenced
this pull request
Mar 21, 2016
oshmem/scoll: Fix bug in basic/barrier algorithm
|
@igor-ivanov - could you please port it to v1.10 and v2.x |
This was referenced Mar 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.