opal: fix coverity issues #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CID 1345825 (1 of 1): Dereference before null check (REVERSE_INULL): ib_proc should not be NULL in this case. Removed the check and added a check for NULL after OBJ_NEW. CID 1269821 (1 of 1): Dereference null return value (NULL_RETURNS): I labeled this one as a false positive (which it is) but the code in question could stand be be cleaned up. Fix CID 1356424 (1 of 1): Argument cannot be negative (NEGATIVE_RETURNS): While trying to silence another Coverity issue another was flagged. Protect the close of fd with if (fd >= 0). CID 70772 (1 of 1): Dereference null return value (NULL_RETURNS): CID 70773 (1 of 1): Dereference null return value (NULL_RETURNS): CID 70774 (1 of 1): Dereference null return value (NULL_RETURNS): None of these are errors and are intentional but now that we have a list release function use that to make these go away. The cleanup is similar to CID 1269821. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CID 1345825 (1 of 1): Dereference before null check (REVERSE_INULL):
ib_proc should not be NULL in this case. Removed the check and added a
check for NULL after OBJ_NEW.
CID 1269821 (1 of 1): Dereference null return value (NULL_RETURNS):
I labeled this one as a false positive (which it is) but the code in
question could stand be be cleaned up.
Fix CID 1356424 (1 of 1): Argument cannot be negative (NEGATIVE_RETURNS):
While trying to silence another Coverity issue another was
flagged. Protect the close of fd with if (fd >= 0).
CID 70772 (1 of 1): Dereference null return value (NULL_RETURNS):
CID 70773 (1 of 1): Dereference null return value (NULL_RETURNS):
CID 70774 (1 of 1): Dereference null return value (NULL_RETURNS):
None of these are errors and are intentional but now that we have a
list release function use that to make these go away. The cleanup is
similar to CID 1269821.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov