RFC: Add support for flag enumerators for MCA variables #1483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new type of enumerator meant to support flag values. The enumerator parses comma-delimited strings and matches each string or value to a list of valid flags. Additionally, the enumerator does some basic checks to see if 1) a flag is valid in the enumerator, and 2) if any conflicting flags are specified. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
This commit uses the new flag "enumerator" to support comma-delimited lists of flags for both the btl and btl atomic flags. After this commit is is valid to specify something like -mca btl_foo_flags self,put,get,in-place. All non-deprecated flags are supported by the enumerator. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Member
Author
|
I should also mention I changed the semantics of the enum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for flag enumerators for MCA variables. A new function and types have been added to
mca_base_var_enum.hto support these enumerators. Usemca_base_var_enum_create_flagto create a flag enumerator with a given set of flags and use the enumerator withmca_base_var_register()/mca_base_pvar_register().Variables using a flag enumerator can take a comma-delimited list of flags. For example, instead of
a user can can now use
The old value way of setting the flags will continue to work.