Skip to content

DNM opal_info: print a component even when it does not contain any parameters #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

DNM opal_info: print a component even when it does not contain any parameters #1514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions opal/runtime/opal_info_support.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,23 @@ static void opal_info_show_mca_group_params(const mca_base_var_group_t *group, m
}
}

/* Print the component before diving into it's paramters. This ensures that
* an enable component is mentioned even when it does not have any explicity
* parameters.
*/
if (opal_info_pretty) {
asprintf (&message, "MCA%s %s %s", requested ? "" : " (disabled)",
group->group_framework,
group->group_component ? group->group_component : "");
opal_info_out(message, message, "---------------------------------------------------");
free(message);
} else {
asprintf (&message, "mca:%s:%s:disabled:%s", group->group_framework,
group_component, requested ? "false" : "true");
opal_info_out("", "", message);
free (message);
}

for (i = 0 ; i < count ; ++i) {
ret = mca_base_var_get(variables[i], &var);
if (OPAL_SUCCESS != ret || ((var->mbv_flags & MCA_BASE_VAR_FLAG_INTERNAL) &&
Expand All @@ -654,7 +671,7 @@ static void opal_info_show_mca_group_params(const mca_base_var_group_t *group, m

for (j = 0 ; strings[j] ; ++j) {
if (0 == j && opal_info_pretty) {
asprintf (&message, "MCA%s %s", requested ? "" : " (disabled)", group->group_framework);
asprintf (&message, "MCA%s %s %s", requested ? "" : " (disabled)", group->group_framework, group->group_component ? group->group_component : "");
opal_info_out(message, message, strings[j]);
free(message);
} else {
Expand Down Expand Up @@ -689,7 +706,7 @@ static void opal_info_show_mca_group_params(const mca_base_var_group_t *group, m

for (j = 0 ; strings[j] ; ++j) {
if (0 == j && opal_info_pretty) {
asprintf (&message, "MCA%s %s", requested ? "" : " (disabled)", group->group_framework);
asprintf (&message, "MCA%s %s %s", requested ? "" : " (disabled)", group->group_framework, group->group_component ? group->group_component : "");
opal_info_out(message, message, strings[j]);
free(message);
} else {
Expand Down