opal_info_support: fix memory leak and refactor for pvars #1522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a memory leak I introduced with a3229c3. Signed-off-by: Karol Mroz <mroz.karol@gmail.com>
Adding component name to the pvar pretty output as well. Further, I think keeping the asprintf()/opal_info_out(msg,msg,------) within the loops is needed to avoid printing any component information (independently for group_vars and group_pvars) in case the upcoming parameters are internal and not to be displayed. Lastly, unnecessarily duplicating the dashed output should not happen as each invocation of opal_info_show_mca_group_params() passes a new group structure which we check. Signed-off-by: Karol Mroz <mroz.karol@gmail.com>
|
Looks like a glitch with the Mellanox build: |
ghost
mentioned this pull request
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4325439 Fixes a memory leak I introduced with the addition of "component_msg".
13979f5 Adds the same kind of component output and separation to group_pvars as we have for group_vars.
A gist of the full output: https://gist.github.com/kmroz/45a01e1dd3d7b8c0fc2e9c62e5edd6ce