config: check for more __sync builtins #1539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the check for __sync builtin atomics to see if the compiler supports both __sync_bool_compare_and_swap and __sync_add_and_fetch. If either of these functions are not available then we can't use the __sync builtins. Fixes open-mpi#1487 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
|
@bosilca Turns out some compiler versions have |
|
👍 |
|
As CAS is the most basic atomic operation if we have it we could implement our own version of all the other atomics. But I am not sure this is worth the effort, especially when we already have atomic implementations for most of the architectures. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the check for __sync builtin atomics to see if the
compiler supports both __sync_bool_compare_and_swap and
__sync_add_and_fetch. If either of these functions are not available
then we can't use the __sync builtins.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov