In case, we do not build Fortran, Fortran 2008 or CXX, the regexp in … #1656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggouaillardet Could You please have a look at the changes in |
|
@hpcraink i am fine with this PR, thanks for filling it. out of curiosity, did you run into the trouble you fixed (e.g. all text deleted) ? |
|
@ggouaillardet Thanks! |
Makefile.ompi-rules
Outdated
| .1in.1: | ||
| @ echo " BUILDING $@" | ||
| @ $(top_srcdir)/ompi/mpi/man/make_manpage.pl \ | ||
| $(AM_V_CC) $(top_srcdir)/ompi/mpi/man/make_manpage.pl \ |
There was a problem hiding this comment.
I think this should be $(OMPI_V_GEN). Shouldn't the echo statement be removed, too?
…make_manpage.pl will delete all lines up to the next ".fi" -- which for functions that do not implement the corresponding interface as code will have all eliminated. Change to delete the man page's content up to the next section header ".SH" Also in case of make V=1, we'd like to see the command line, too. Amend OMPI_Affinity_str according to the other man-pages definitions.
|
Test passed. |
|
bot:retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…make_manpage.pl will delete all lines up to the next ".fi" -- which for functions that do not implement the corresponding interface "as code" will have all text eliminated. Change regexp to delete this language-specific content up to the next newline+section header ".SH"
Also in case of make V=1, we'd like to see the command line, too (see Makefile.ompi-rules)
Amend OMPI_Affinity_str according to the other man-pages definitions.