Skip to content

Conversation

@ggouaillardet
Copy link
Contributor

No description provided.

@ggouaillardet
Copy link
Contributor Author

@jsquyres can you please have a look at it ?
i naively thought autotools would take care of that ... but it seems the .c files generated by flex must be manually removed

@jsquyres
Copy link
Member

No, we don't want the clean target to remove lex files -- this will remove the *lex.c generated files from tarballs. I.e., it will mean that users will need to have flex installed.

If anything, the maintainer-clean target could remove these files (i.e., the maintainer-clean-local target).

@jsquyres
Copy link
Member

bot:retest

@ggouaillardet
Copy link
Contributor Author

@jsquyres i updated the PR and now uses the maintainer-clean-local target

@jsquyres
Copy link
Member

👍

@ggouaillardet ggouaillardet merged commit 57978a7 into open-mpi:master Jun 1, 2016
fengyuleidian0615 added a commit to fengyuleidian0615/ompi that referenced this pull request Aug 5, 2016
On top of:
commit 57978a7
Merge: 5d4bcce 5f565df
Author: Gilles Gouaillardet <ggouaillardet@users.noreply.github.com>
Date:   Wed Jun 1 13:06:21 2016 +0900

    Merge pull request open-mpi#1717 from ggouaillardet/topic/lex_cleanup

    configury: clean the flex generated .c files

Signed-off-by: Fan Du <fan.du@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants