mpirun.1in: add descriptions of new options #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
force-pushed
the
pr/mpirun-timeout-and-friends
branch
from
19cd146 to
4a98d2a
Compare
|
bot:retest |
|
Can you add the new options to the completion files or should I? |
|
:bot:retest: message_rate_th is anything but a message rate test. It is a test at how fast we can get unexpected messages off the queue when using threads. Right now ob1 needs more than 5 mins to run this test when bound to core so Mellanox has restored the timeout to 10min. Should have the performance improved in the next month or so. |
|
The proposed changes look fine to me |
|
bot:retest |
jsquyres
force-pushed
the
pr/mpirun-timeout-and-friends
branch
from
4a98d2a to
7f56824
Compare
|
Added description of ETIMEDOUT return value. |
Add descriptions for the new --report-state-on-timeout and --get-stack-traces options. Also add --timeout, and cross-reference MPIEXEC_TIMEOUT with it. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Add the following to zsh shell completion: * --get-stack-traces * --report-state-upon-timeout * --timeout Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
force-pushed
the
pr/mpirun-timeout-and-friends
branch
from
7f56824 to
cf27ec3
Compare
|
@hjelmn I added the zsh completions for the new mpirun options. Can you review? |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add descriptions for the new --report-state-on-timeout and --get-stack-traces options.
Also add --timeout, and cross-reference MPIEXEC_TIMEOUT with it.
Signed-off-by: Jeff Squyres jsquyres@cisco.com
@rhc54 Please review before we merge the new language to master. Thanks.