ompi/datatype: Fix args of HINDEXED_BLOCK #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to MPI-3.1 P.121, `ni` for `MPI_COMBINER_HINDEXED_BLOCK` should be `2`, not `2 + count`. This bug was introduced in 113b45b (when `MPI_Type_create_hindexed_block` support is added in Open MPI) and fixed partially in 7f5314e and 8de9398. This commit fixes the remaining part. Probably this bug has no user impact. It only consumes a bit more memory.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MPI-3.1 P.121,
niforMPI_COMBINER_HINDEXED_BLOCKshould be2, not2 + count.This bug was introduced in 113b45b (when
MPI_Type_create_hindexed_blocksupport was added in Open MPI) and fixed partially in 7f5314e and 8de9398. This commit fixes the remaining part.Probably this bug has no user impact. It only consumes a bit more memory on one-sided communication (pt2pt OSC).
@bosilca Please review.