Make libevent use internal random #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Di0gen @artpol84 @jladd-mlnx Can you please look at this Mellanox Jenkins failure? |
|
|
||
| # We added this in order to enforce the use of internal random | ||
| # function to prevent pertubing the random seed of the user. | ||
| # libevent uses random function in poll(), select() and evutil(). |
There was a problem hiding this comment.
Slightly tweak the wording:
We define "random" to be "opal_random" so that Libevent will not use random(3) internally (and potentially unexpectedly perturb values returned by rand(3) to the application).
|
Please use a git commit message as described here: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html |
|
@jsquyres checking |
|
Just to cross-reference: Ralph filed this issue upstream with libevent: libevent/libevent#384 |
This commits changed rand(3) and family in libevent to use internal random function provided in opal to prevent pertubing user's random seed. Fixes open-mpi#1877
|
@thananon Please PR this to v2.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits changed rand() and family in libevent to use internal random function provided in opal to prevent pertubing user's random seed. (from issue #1877)
Again, this will not solve the problem if the user use their own external libevent.
Modified from @ggouaillardet patch.