btl/openib: Disqualify rdmacm CPC if MPI_THREAD_MULTIPLE #2133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Above commit is merged with master branch and needs to be cherry-picked into v2.x as well. |
hjelmn
approved these changes
Oct 12, 2016
hjelmn
requested changes
Oct 12, 2016
Member
hjelmn
left a comment
hjelmn
left a comment
There was a problem hiding this comment.
You need to remove the include of the ompi header here.
jsquyres
reviewed
Oct 12, 2016
| #include "btl_openib_ip.h" | ||
| #include "btl_openib_ini.h" | ||
|
|
||
| #include "ompi/runtime/mpiruntime.h" |
Member
There was a problem hiding this comment.
@hjelmn is referring to this line -- you can't include an OMPI header in OPAL source code.
The rdmacm CPC in the openib BTL is not thread safe. The rdmacm CPC should disqualify itself (instead of failing in random ways) if MPI_THREAD_MULTIPLE is the thread level. Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
Member
|
adding pushback label here till mpiruntime.h is removed |
Contributor
Author
jsquyres
approved these changes
Oct 13, 2016
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
@hppritcha Once @hjelmn approves the changes and CI finishes, good to go.
hjelmn
approved these changes
Oct 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rdmacm CPC in the openib BTL is not thread safe. The rdmacm CPC
should disqualify itself (instead of failing in random ways) if
MPI_THREAD_MULTIPLE is the thread level.
Fixes #1848
Signed-off-by: Potnuri Bharat Teja bharat@chelsio.com