v2.x flag enumerators and accumulate_ordering info key #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new type of enumerator meant to support flag values. The enumerator parses comma-delimited strings and matches each string or value to a list of valid flags. Additionally, the enumerator does some basic checks to see if 1) a flag is valid in the enumerator, and 2) if any conflicting flags are specified. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit b15a450)
Fixes CID 1357979: Resource leak (RESOURCE_LEAK): flags array was being leaked. Fixed. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 6df5a66)
This commit fixes a typo in flag enumeration that can cause the parser to miss valid flags or crash. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 37e9e2c)
(cherry picked from commit 1baed49)
This commit adds support for the MPI-3.1 accumulate_ordering info key. The default value is rar,war,raw,waw and is supported using an MCA variable flag enumerator. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 5126da5)
This commit uses the new flag "enumerator" to support comma-delimited lists of flags for both the btl and btl atomic flags. After this commit is is valid to specify something like -mca btl_foo_flags self,put,get,in-place. All non-deprecated flags are supported by the enumerator. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 7572c8b)
Signed-off-by: Nathan Hjelm <hjelmn@me.com>
|
@jsquyres Once this is merged I have one more feature I want to bring over. |
|
@hjelmn what is the "one more feature" to bring over? |
|
@hppritcha It was discussed on the call last week. It is the support for directly using AMOs for MPI_Fetch_and_op and MPI_Compare_and_swap. I needed the mpool rewrite and this before I can do the cherry-pick to avoid dealing to merge conflicts. |
|
@hjelmn Still need a review. |
|
Doh! I'm assigned as the reviewer. I'll review... |
|
bot:lanl:retest |
|
@hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.