mpi/cxx: isolate internal headers from C++ bindings #2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@hjelmn Did this get the additional fixes from master that were put in after the fact? |
This commit adds some glue code to support the C++ bindings and updates the bindings to use the new glue code. This protects our internal headers (which are C99) from C++. This is done as a quick workaround to compilation errors when the legacy C++ bindings are requested. Fixes open-mpi#2055 Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit c6464ca)
Fixes open-mpi#2179 (cherry picked from commit 95e63d7)
ISO C forbids mixing object pointer and function pointer (cherry picked from commit b95e243)
and avoid #includ'ing stuff that breaks C++ compilers (cherry picked from commit 974dd64)
hjelmn
force-pushed
the
v2.0.x_cxx_isolation
branch
from
2c314f4 to
a9e295f
Compare
jsquyres
approved these changes
Oct 12, 2016
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit ab0a005) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
jsquyres
approved these changes
Oct 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some glue code to support the C++ bindings and
updates the bindings to use the new glue code. This protects our
internal headers (which are C99) from C++. This is done as a quick
workaround to compilation errors when the legacy C++ bindings are
requested.
Fixes #2055
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
(cherry picked from commit c6464ca)