v2.0.2: usnic bug fixes #2169
Merged
v2.0.2: usnic bug fixes #2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
force-pushed
the
pr/v2.0.2/usnic-bug-fixes-2
branch
from
9c0b8ac to
056aa37
Compare
With libfabric v1.4, the usnic provider changed the values of its fabric and domain name strings (compared to libfabric <v1.4). Update the Open MPI usNIC BTL to handle both pre-v1.4 and v1.4 fabric/domain names. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 6f5e377)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 9717bcb)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit f56b16f)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 87a5ccc)
The previous message was unhelpful / confusing. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit b138138)
There are critical usnic libfabric AV insert bugs before v1.3, so don't allow any version prior to v1.3 at run time (still allow *compiling* with earlier versions, though, since the ABI guarantees allow us to compile with an earlier libfabric and run with a later libfabric). Switch to using fi_version() to check the version (instead of calling fi_getinfo()) as a potentially lighter-weight / simpler solution. This allows us to only call fi_getinfo() once. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 345c07a)
We only support running with libfabric v1.3 or greater. So it's safe to remove the legacy/adaptive cq_readerr() behavior. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 8b77359)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 67684be)
jsquyres
force-pushed
the
pr/v2.0.2/usnic-bug-fixes-2
branch
from
80b7eed to
9ed1145
Compare
bturrubiates
approved these changes
Oct 5, 2016
ompiteam
approved these changes
Oct 5, 2016
Contributor
ompiteam
left a comment
ompiteam
left a comment
There was a problem hiding this comment.
@bturrubiates approved; filing an "approved" by an OMPI committer so that Github accepts it.
Member
Author
|
@hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bturrubiates This is the same as #2157, but with several more bug fix commits that hadn't yet come over from master --> v2.0.x (but were already on v2.1.x). You should probably review individual commits; not the union of all commits.
A few commits had to be back-ported here (i.e., to the v2.0.x branch) because the usNIC BTL on master/v2.1.x support MPI_THREAD_MULTIPLE, but the usNIC BTL on v2.0.x does not.