v2.0.x: osc-portals4: fix offset bug in raccumulate() #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
bot:mellanox:retest |
Member
|
@tkordenbrock Can you please rebase? That will fix the travis OS X failure. |
This commit fixes a bug where the remote offset was used as both the local and remote offset. Thanks to @PDeveze for the patch.
tkordenbrock
force-pushed
the
topic/v2.0.x/raccumulate.offset.fix
branch
from
edc6216 to
b9bbc49
Compare
Member
Author
|
Sure. Rebased and pushed. |
Member
Author
|
bot:retest |
Member
|
@tkordenbrock Github pro tip: if you push new commits to a PR (or change the branch on a PR in any way), Github will automatically kick off all the CI again -- no need for a bot retest command. |
Member
|
@hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where the remote offset was used as both
the local and remote offset.
Thanks to @PDeveze for the patch.
(cherry-pick of c536e11)