Remove ptmalloc2 hooks from v2.1.x #2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
Because of the removal of the linux memory component it is no longer necessary to initialize the memory component in opal_init(). This commit moves the initialization to the creation of the first rcache component. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit c2b6fbb) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
This commit fixes an error in the failure path of leave_pinned. When the rcache tries to enable leave_pinned but leave_pinned was not specifically requested (opal_leave_pinned == -1) the code was erroneously printing an error and returning NULL. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> (cherry picked from commit 25a97af) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
jsquyres
requested changes
Oct 13, 2016
| available, this will cause memory corruption. Refuse to run. | ||
| Right now, ptmalloc2 is the only memory manager that we have on | ||
| OS's that support OpenFabrics that provide both FREE and MUNMAP | ||
| support, so the following test is [currently] good enough... */ |
Member
There was a problem hiding this comment.
@hjelmn You just deleted the ptmalloc component, so is this still needed?
Member
There was a problem hiding this comment.
And it may not be true anymore.
Member
|
@hppritcha and I discussed: this is a code cleanup PR, and is ok for v2.1.0. |
Member
|
bot:lanl:retest |
Member
|
@gpaulsen Can IBM test / review this? |
jsquyres
requested changes
Oct 25, 2016
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Please add a Signed-off-by line to this PR's commit.
Member
|
bot:lanl:retest |
jsquyres
previously approved these changes
Nov 7, 2016
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
All commits signed off. Thanks!
Member
|
Well, I read the code, but didn't fully understand it. I'll download it and give it a whirl. |
Member
|
Sorry, getting back to this. I'll do this today. |
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Jan 24, 2017
Follow on to open-mpi#2217. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres
approved these changes
Jan 24, 2017
Member
|
Correction: review addressed in #2804. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v2.0.x we added new memory hooks to replace ptmalloc2. We let the old hooks stick around but disabled them by default. We agreed to remove the hooks entirely in v2.1.x. If that is still the case please merge this PR.