v2.x: add support for MPI_IN_PLACE in MPI_Ialltoall* #2235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Chris Ward for the report Many thanks to George for the guidance (cherry picked from commit open-mpi/ompi@1e0f591)
(cherry picked from commit open-mpi/ompi@7cae36f)
bosilca
approved these changes
Oct 18, 2016
|
@hppritcha Good to go. |
|
@ggouaillardet It looks like git messed up the cherry pick on your first change to the mpi/c/ interface. It just updated the copyright, but not the code. I think it is because the code structure is slightly different than } else if (MPI_IN_PLACE == sendbuf || MPI_IN_PLACE == recvbuf) {
return OMPI_ERRHANDLER_INVOKE(MPI_COMM_WORLD, MPI_ERR_ARG,
FUNC_NAME);So in the v2.x series this is still disabled. I can work up a patch tomorrow. |
ggouaillardet
added a commit
to ggouaillardet/ompi
that referenced
this pull request
Nov 2, 2016
…nicators open-mpi/ompi@1ee1e19 incorrectly cherry-picked open-mpi/ompi@7cae36f fix that by backporting all MPI param checks from master Refs: open-mpi#2235 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
jjhursey
pushed a commit
to jjhursey/ompi
that referenced
this pull request
Nov 2, 2016
…nicators open-mpi/ompi@1ee1e19 incorrectly cherry-picked open-mpi/ompi@7cae36f fix that by backporting all MPI param checks from master Refs: open-mpi#2235 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit fa8b85a) Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
PR #2339 fixed the issue noted in the previous comment. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.