coll/libnbc: Fix error path on internal error #2273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IBM CI failure due to github DNS issue |
bosilca
approved these changes
Oct 21, 2016
|
bot:lanl:retest |
|
bot:ibm:retest |
jsquyres
previously requested changes
Oct 25, 2016
* If an error is detected internal to libnbc (e.g., PML truncation error) this patch makes sure that the request is completed and the `MPI_ERROR` field is set approprately. * Make an attempt to cleanup outstanding requests before returning. - This is a "best attempt" since not all PMLs support canceling requests. (cherry picked from commit 8748e54) Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
jjhursey
force-pushed
the
topic/v2.x-libnbc-error-path
branch
from
83e7853 to
91cd981
Compare
jjhursey
dismissed
jsquyres’s stale review
Commit message has been updated with sign-off
|
@jsquyres @hppritcha I think this is ready to merge. Any reservations? |
|
You don't need to dismiss my review; you can mention that you've fixed it and let me approve the changes. 😄 |
|
@hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch makes sure that the request is completed and the
MPI_ERRORfield is set approprately.
(cherry picked from commit 8748e54)