v2.x: pml/ob1: always reset recv request type #2292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjelmn
approved these changes
Oct 25, 2016
|
@hppritcha Good to go. |
jsquyres
previously requested changes
Oct 25, 2016
recvreq->req_recv.req_base.req_type should always be set before invoking MCA_PML_OB1_RECV_REQUEST_INIT(recvreq, ...) otherwise, the previous type might be set, and you could end up with MPC_PML_REQUEST_IMPROBE when MCA_PML_REQUEST_RECV is expected. Thanks Chris Pattison for the report and test case. Fixes open-mpi#2275 (cherry picked from commit open-mpi/ompi@4a886ac) Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
and fix a typo in a comment Thanks George for the patch (cherry picked from commit open-mpi/ompi@8e788b5) Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp>
ggouaillardet
force-pushed
the
topic/v2.x/pml_ob1_recv_request_type_reset
branch
from
77e8f40 to
a266d48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.