v2.x: create_tarball.sh: update snapshot filename #2346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
changed the title
|
@rhc54 and/or @hppritcha: can you review all 3 "rename nightly snapshot" PRs so that we can merge them for tonight's builds? #2345 #2346 #2347 |
hppritcha
reviewed
Nov 2, 2016
contrib/nightly/create_tarball.sh
Outdated
| # Nightly tarballs are named in this format: | ||
| # openmpi-${BRANCHNAME}-${YYYYMMDDHHMM}-${SHORTHASH}.tar.${COMPRESSION} | ||
| timestamp=`date '+%Y%m%d%H%M'` | ||
| githash=`git show '--pretty=format:%h'` |
There was a problem hiding this comment.
I got curious and wanted to see what git command would show. For me it ends up being a long string starting with the shortened hash.
hppritcha
approved these changes
Nov 2, 2016
|
Looks like this would be better: I'll update. |
Nightly snapshots will now be named:
openmpi-${BRANCHNAME}-${YYYYMMDDHHMM}-${SHORTHASH}.tar.${COMPRESSION}.
Fixes open-mpi#2337
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
(cherry picked from commit 78d1e4e)
Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit a47ad86)
jsquyres
force-pushed
the
pr/v2.x/rename-nightly-snapshot-tarballs
branch
from
6b25075 to
52a3ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly snapshots will now be named:
openmpi-${BRANCHNAME}-${YYYYMMDDHHMM}-${SHORTHASH}.tar.${COMPRESSION}.
Fixes #2337
Signed-off-by: Jeff Squyres jsquyres@cisco.com
(cherry picked from commit 78d1e4e)