Protect the tcp_endpoints list from concurrent accesses. #2398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks Gilles for your help. Signed-off-by: George Bosilca <bosilca@icl.utk.edu>
bosilca
force-pushed
the
topic/tcp_endpoints_mutex
branch
from
eeda7b1 to
d0dddef
Compare
Member
|
Is there a corresponding commit on master? |
Member
Author
|
This is the PR for master, that will be pulled in once we agree on the solution. |
Member
|
@ggouaillardet @bosilca Should we merge to master / PR to v2.0.x and v2.x? |
Member
Author
|
I will let @ggouaillardet comment and merge it if he is happy with. |
Contributor
|
i read the patch and it looks good to me, so i will go ahead and merge it. i will fully test it next week, and then PR to the release branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will fix some [hopefully all] of the segfaults when TCP progress thread is on. Thanks Gilles for your help.