Skip to content

v2.0.x: minor comm cid code cleanups #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2016
Merged

v2.0.x: minor comm cid code cleanups #2507

merged 2 commits into from
Dec 3, 2016

Conversation

@jsquyres
Copy link
Member

@jsquyres jsquyres commented Dec 3, 2016

Thanks to @OMGtechy for the submission.

@hppritcha Please review. Can easily slip to v2.0.3 if it's too close for v2.0.2.

@OMGtechy @jsquyres
Fixed -Werror=unused-result warnings in comm_cid.c by adding error ch…
b403558 
…ecking

Signed-off-by: Joshua Gerrard <enquiries@joshuagerrard.com>
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>

(cherry picked from commit 7cf5de1)
@OMGtechy @jsquyres
Swapped use of fprintf for opal_output_verbose
79c4a78 
Signed-off-by: Joshua Gerrard <enquiries@joshuagerrard.com>
Signed-off-by: Jeff Squyres <jsquyres@cisco.com>

(cherry picked from commit d5a45bc)
@jsquyres jsquyres added this to the v2.0.2 milestone Dec 3, 2016
@jsquyres jsquyres merged commit 4caafba into open-mpi:v2.0.x Dec 3, 2016
@jsquyres jsquyres deleted the pr/v2.0.x/minor-comm-cid-code-cleanups branch January 11, 2017 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hppritcha hppritcha hppritcha approved these changes

Assignees

@hppritcha hppritcha

Labels

code cleanup RM approved

Projects

None yet

Milestone

v2.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@jsquyres @hppritcha @OMGtechy