v2.x: configury: check the existence of perl #2516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
bot:ibm:retest |
Member
|
bot:mellanox:retest |
jsquyres
approved these changes
Dec 7, 2016
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Assuming CI passes, looks good to me.
I don't see a real need to bring this to OMPI v2.x, though -- can be a nice enhancement for v3.x.
Member
|
Hah -- this is v2.x. Ok. @ggouaillardet Why is this still DNM? |
perl is required by ompi/mpi/man/make_manpage.pl, that is even used in opal. so simply aborts at configure time if perl is not available Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit open-mpi/ompi@5bb3efd)
perl is now mandatory to build Open MPI, so there is no need to check for it Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit open-mpi/ompi@c8b51a2)
ggouaillardet
force-pushed
the
topic/v2.x/configury_check_perl
branch
from
3ed0b80 to
bb8ee61
Compare
Contributor
Author
|
@jsquyres i was waiting for an other commit (remove some now dead code) |
Member
|
@ggouaillardet Ok. @hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perl is required by ompi/mpi/man/make_manpage.pl, that is even used in opal.
so simply aborts at configure time if perl is not available
Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp
(cherry picked from commit 5bb3efd)