v2.0.x: ompi/debuggers: make the binary bit reproducible #2556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of compilation date __DATE__, use a MPI_Get_library_version() like string Thanks Alastair McKinstry for the report Fixes open-mpi#2518 Signed-off-by: Gilles Gouaillardet <gilles@rist.or.jp> (cherry picked from commit open-mpi/ompi@4d8f606)
jsquyres
approved these changes
Dec 13, 2016
There was a problem hiding this comment.
@hppritcha I'm good with this for v2.0.2, but don't have strong feelings about it. It could wait until v2.0.3, too.
|
@jsquyres I'm going ahead and merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of compilation date DATE, use a MPI_Get_library_version() like string
Thanks Alastair McKinstry for the report
Fixes #2518
Signed-off-by: Gilles Gouaillardet gilles@rist.or.jp
(cherry picked from commit 4d8f606)