Skip to content

Conversation

@jjhursey
Copy link
Member

Missing header found by MTT using either GNU or XL compilers and the following compiler option:
-Werror,-Wimplicit-function-declaration

timer_linux_component.c:167:9: error: implicit declaration of function 'opal_show_help' is invalid
in C99 [-Werror,-Wimplicit-function-declaration]
        opal_show_help("help-opal-timer-linux.txt", "monotonic not supported", true);
        ^1 warning and 1 error generated.
Error while processing timer_linux_component.c.

This was fixed as part of a larger commit on master, so there is no commit to cherry-pick.

@jjhursey jjhursey added the bug label Jan 11, 2017
@jjhursey jjhursey added this to the v2.1.0 milestone Jan 11, 2017
@jjhursey jjhursey requested a review from jsquyres January 11, 2017 16:38
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey jjhursey force-pushed the fix/v2.x/timer-header branch from 037268d to dee73d9 Compare January 11, 2017 16:39
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hppritcha Seems very low risk / no brainer.

@jjhursey
Copy link
Member Author

@hppritcha @jsquyres Can we merge this in? It's blocking our MTT testing on this branch.

@jsquyres jsquyres merged commit 1e0487a into open-mpi:v2.x Jan 13, 2017
@jjhursey jjhursey deleted the fix/v2.x/timer-header branch January 26, 2017 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants