ess/hnp: add support for forwarding additional signals (#2712) #2726
Conversation
|
:bot:retest:mellanox |
|
I keep getting the old files when I try to review this, and then when I try to comment it complains that things are stale. I think github is confused. will come back in a bit and see if it straightens itself out. |
orte/mca/ess/hnp/Makefile.am
Outdated
| # $HEADER$ | ||
| # | ||
|
|
||
| dist_ortedata_DATA = help-ess-hnp.txt |
There was a problem hiding this comment.
this needs to be dist_ompidata_DATA for v1.10
orte/mca/ess/hnp/ess_hnp_component.c
Outdated
| orte_ess_hnp_component_open, | ||
| orte_ess_hnp_component_close, | ||
| orte_ess_hnp_component_query | ||
| orte_ess_hnp_component_query, |
| return ORTE_SUCCESS; | ||
| } | ||
|
|
||
| /* instantiate the class */ |
There was a problem hiding this comment.
where did the rest of the component file changes go?
There was a problem hiding this comment.
That is a really good question.... Will redo the merge.
hjelmn
force-pushed
the
v1.10_ess_hnp
branch
2 times, most recently
from
1f8da31 to
55b43d0
Compare
|
I don't know why its taking so long to update the status field of the PR, but the lanl-disable-dlopen failed with a compiler failure. https://jenkins.open-mpi.org/jenkins/job/ompi_master_pr_disable_dlopen/695/console |
|
Build Failed with GNU compiler! Please review the log, and get in touch if you have questions. Gist: https://gist.github.com/a25ed9c9085dc935aee279053a09f086 |
|
Build Failed with XL compiler! Please review the log, and get in touch if you have questions. Gist: https://gist.github.com/6dc938824bf8448745e65523f8604d2d |
* ess/hnp: add support for forwarding additional signals This commit adds support to the hnp ess module to forward additional signals beyond the default SIGUSR1, SIGUSR2, SIGSTP, and SIGCONT. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> * Generalize this a bit to allow a broader range of signals to be forwarded. Turns out that SIGURG is now a "standard" signal, though the value differs across systems. So setup to forward it (and some friends) if they are defined. Allow users to provide the signal name (instead of the integer value) as the value of even the more common signals does vary across systems. Don't limit the number that can be supported. Signed-off-by: Ralph Castain <rhc@open-mpi.org> * ess/hnp: fix some bugs in the signal forwarding code This commit fixes two bugs: - signals_set needs to be set even if no signals are being forwarded. If it is not set we will SEGV in libevent if ess_hnp_forward_signals == none. - SIGTERM and SIGHUP are handled with a different type of handler. Do not allow the user to specify these to be forwarded. Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov> * We are sure to get "dinged" if error messages aren't nicely output via show_help, so do so here Signed-off-by: Ralph Castain <rhc@open-mpi.org> (cherry picked from commit 110840f) Signed-off-by: Nathan Hjelm <hjelmn@lanl.gov>
4 participants
This commit adds support to the hnp ess module to forward additional
signals beyond the default SIGUSR1, SIGUSR2, SIGSTP, and SIGCONT.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
Signed-off-by: Ralph Castain rhc@open-mpi.org
This commit fixes two bugs:
signals_set needs to be set even if no signals are being
forwarded. If it is not set we will SEGV in libevent if
ess_hnp_forward_signals == none.
SIGTERM and SIGHUP are handled with a different type of handler. Do
not allow the user to specify these to be forwarded.
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov
Signed-off-by: Ralph Castain rhc@open-mpi.org
(cherry picked from commit 110840f)
Signed-off-by: Nathan Hjelm hjelmn@lanl.gov