Pr/sharedfp append fix v2.x #2786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert the logic of io_ompio_sharedfp_lazy_open. The user now has to explicitely disable shared fp in order for the structures not to be allocated. Otherwise, resetting the shared fp e.g. in case the file was opened in append mode will not work correctly, the code could deadlock. Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu>
Member
|
Just like #2787: @edgargabriel Got a compile fail: Can you have a look? |
Member
Author
|
argh, copy-and-paste error, a line is missing, Will fix. |
Fixes a bug reported on the mailing list. ompio did only reposition the individual file pointer when the file was opened in append mode. Set the shared file pointer also to point to the end of the file, similarly to the individual file pointer. This is the equivalent to commit d3a8d38 on master, cannot be cherry-picked because of differences in the organization of the ompio files ( usage of mca/common/ompio on master). Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu>
edgargabriel
force-pushed
the
pr/sharedfp-append-fix-v2.x
branch
from
f584119 to
cfda4b8
Compare
jsquyres
approved these changes
Jan 24, 2017
Member
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Same as #2787 (review) -- would be nice to see another PR to replace opal_output's with opal_show_helps.
Member
|
@hppritcha Good to go. |
Member
|
Shoot -- @edgargabriel just mentioned on the v2.0.x version (#2787 (comment)) that we should have waited merging. My fault for not seeing that fast enough... |
Member
Author
|
I will provide a separate pr for 2.x for the outstanding item. its probably more important to get it in correctly for 2.0.x right now |
Member
|
Thanks @edgargabriel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported on the mailing list. ompio did only reposition the individual
file pointer when the file was opened in append mode. Set the shared file
pointer also to point to the end of the file, similarly to the individual
file pointer.
This is the equivalent to commit d3a8d38
on master, cannot be cherry-picked because of differences in the organization
of the ompio files ( usage of mca/common/ompio on master).