Pr/sharedfp append fix v2.x #2862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a file is opened a second time for shared file pointer operations, avoid setting the create and exclusive flag. Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu>
it looks like disabling the lazy_open flag for sharedfp components revealead a bug that lead to a crash in file_close in some tests. Make sure the SHAREDFP_IS_SET flag is correctly set (and not overwritten again), and we use that to avoid a double-free of the communicator. This is equivalent to commit commit f5289a1 on master. The commit cannot be cherry-picked due to the differences in the organization of the ompio files (ompio uses now common/ompio for many files). Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu>
Member
Author
|
the failure in LANL-disable-dlopen does not seem related to this pr. --snip--
|
Member
|
and try this again: |
Member
Author
|
@jsquyres since you reviewed the euqivalent for the 2.0.2 release, would you mind doing the same for the 2.1 release? |
jsquyres
approved these changes
Feb 17, 2017
Member
|
@hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the second part of the sharedfp append fix for the v2.x branch. For the 2.0.x branch, all four commits were merged at the same time.