osc/base: Detect unsupported data types and abort #2928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using MPI_MINLOC or MPI_MAXLOC with the following data types leads to data corruption: * MPI_DOUBLE_INT * MPI_LONG_INT * MPI_SHORT_INT * MPI_LONG_DOUBLE_INT Detect this print a error message and abort. This workaround should be removed once the following issue is resolved: * open-mpi#1666 Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> (cherry picked from commit 94f92f6) Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
Refs PR #2832 |
jsquyres
requested changes
Feb 7, 2017
gpaulsen
approved these changes
Feb 7, 2017
|
@jjhursey I think this patch will only work for osc/pt2pt. osc/rdma will probably need a similar check in ompi_osc_rdma_rget_accumulate_internal() |
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
jjhursey
force-pushed
the
topic/ibm/v2.x/osc-base-dt-abort
branch
from
362ff7b to
13d965f
Compare
|
I've updated this PR to reflect the changes in PR #2927 - I'll keep them in sync if there are any further changes necessary. |
Using MPI_MINLOC or MPI_MAXLOC with the following data types leads to data corruption: * MPI_DOUBLE_INT * MPI_LONG_INT * MPI_SHORT_INT * MPI_LONG_DOUBLE_INT Detect this print a error message and abort. This workaround should be removed once the following issue is resolved: * open-mpi#1666 Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
jjhursey
force-pushed
the
topic/ibm/v2.x/osc-base-dt-abort
branch
from
13d965f to
cc5747f
Compare
|
bot:mellanox:retest |
jsquyres
approved these changes
Feb 20, 2017
|
@hppritcha Once CI finishes, good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using MPI_MINLOC or MPI_MAXLOC with the following data types
leads to data corruption:
Detect this print a error message and abort.
This workaround should be removed once the following issue is resolved:
Signed-off-by: Joshua Hursey jhursey@us.ibm.com
(cherry picked from commit 94f92f6)
Signed-off-by: Joshua Hursey jhursey@us.ibm.com