-
Notifications
You must be signed in to change notification settings - Fork 931
v2.x: add support for 'external32' representation #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hppritcha
merged 9 commits into
open-mpi:v2.x
from
ggouaillardet:topic/v2.x/external_support
Feb 21, 2017
Merged
v2.x: add support for 'external32' representation #2996
hppritcha
merged 9 commits into
open-mpi:v2.x
from
ggouaillardet:topic/v2.x/external_support
Feb 21, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit open-mpi/ompi@1ff2a38)
The datatype must satisfy the same constraints as for the corresponding communication function (send for pack and recv for unpack). (cherry picked from commit open-mpi/ompi@221e6e2)
(cherry picked from commit open-mpi/ompi@639f4b1)
provide external32 support). Add a pack function allowing to provide send conversion (needed on little endian machine in order to pack in the external32 format). (cherry picked from commit open-mpi/ompi@cf2bb20)
(back-ported from commit open-mpi/ompi@8da67f5)
Use htonl and htons to check that the packed data is indeed the correct data. (cherry picked from commit open-mpi/ompi@383b78d)
(cherry picked from commit open-mpi/ompi@0f9ddbe)
…D_CONVERSION && ! CONVERTOR_HOMOGENEOUS (cherry picked from commit open-mpi/ompi@cd829e4)
(cherry picked from commit open-mpi/ompi@63eec55)
277d3cc to
fd29946
Compare
|
this is a cherry-pick of the commits from #1509 |
bosilca
approved these changes
Feb 17, 2017
|
Per discussion on the other thread, some commits are not signed off here because they were cherry-picked from master from before we required Signed-off-by. Hence, they're covered by the prior IP agreement, and are therefore still ok. @hppritcha Good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks Thomas Gastine for the report
Fixes #2985