Skip to content

v2.0.x: add support for 'external32' representation #2997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 21, 2017
Merged

v2.0.x: add support for 'external32' representation #2997

merged 9 commits into from
Feb 21, 2017

Conversation

@ggouaillardet
Copy link
Contributor

@ggouaillardet ggouaillardet commented Feb 16, 2017 •
edited
Loading

Thanks Thomas Gastine for the report

Fixes #2985

@ggouaillardet ggouaillardet mentioned this pull request Feb 16, 2017
Open
bosilca and others added 9 commits February 17, 2017 09:18
@bosilca @ggouaillardet
Dump also the blockLen.
342145d 
(cherry picked from commit open-mpi/ompi@1ff2a38)
@ggouaillardet
Add the datatype checks to the pack/unpack functions.
c4975c6 
The datatype must satisfy the same constraints as for the
corresponding communication function (send for pack and
recv for unpack).

(cherry picked from commit open-mpi/ompi@221e6e2)
@bosilca @ggouaillardet
Add a small optimization for the vector of predefined datatype.
148929b 
(cherry picked from commit open-mpi/ompi@639f4b1)
@bosilca @ggouaillardet
Always build support for HETEROGENEOUS environment (this is needed to
1f4697d 
provide external32 support). Add a pack function allowing to
provide send conversion (needed on little endian machine in
order to pack in the external32 format).

(cherry picked from commit open-mpi/ompi@cf2bb20)
@bosilca @ggouaillardet
Add a test to validate the support for external32.
d4ea2be 
(back-ported from commit open-mpi/ompi@8da67f5)
@bosilca @ggouaillardet
Validate the packed data
e7f2121 
Use htonl and htons to check that the packed data is
indeed the correct data.

(cherry picked from commit open-mpi/ompi@383b78d)
@ggouaillardet
test/datatype/external32: make it a non MPI application
6c3ee7b 
(cherry picked from commit open-mpi/ompi@0f9ddbe)
@ggouaillardet
opal/datatype: only use opal_pack_general[_checksum] if CONVERTOR_SEN…
77e68fc 
…D_CONVERSION && ! CONVERTOR_HOMOGENEOUS

(cherry picked from commit open-mpi/ompi@cd829e4)
@ggouaillardet
datatype/external32: fix test
e282613 
(cherry picked from commit open-mpi/ompi@63eec55)
@ggouaillardet ggouaillardet force-pushed the topic/v2.0.x/external_support branch from 3180cf4 to e282613 Compare February 17, 2017 00:19
@ggouaillardet ggouaillardet added this to the v2.0.3 milestone Feb 17, 2017
@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Feb 17, 2017

this is a cherry-pick of the commits from #1509

jsquyres
jsquyres requested changes Feb 20, 2017
View reviewed changes
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please sign off these commits?

@ggouaillardet
Copy link
Contributor Author

ggouaillardet commented Feb 21, 2017

@jsquyres these are old commits (e.g. long before we moved to the CA) i cherry-picked from master
in a previous PR, we agreed there was no need to have them signed off.
i still need to review the change requested by @bosilca, and if you insist, i will also sign off all the commits.
(note some of them are authored by @bosilca, shall i sign them off ? ask George to do it ? ask George to allow me to do it for him ?)

@bosilca
Copy link
Member

bosilca commented Feb 21, 2017

@ggouaillardet feel free to sign them if they need to be signed. However, we should have a flexible rule that allows us to cherry-pick old commits (from a time where we were bound by the signed agreement).

@rhc54
Copy link
Contributor

rhc54 commented Feb 21, 2017

Indeed, we do have such a policy - cherry-picking of old commits does not require a sign off. This is just an artifact of a limitation in the automated checker. We shouldn't set policy based on that limitation, and that is what we had previously agreed upon.

@jsquyres
Copy link
Member

jsquyres commented Feb 21, 2017

Ok.

@jsquyres
Copy link
Member

jsquyres commented Feb 21, 2017

@hppritcha Good to go

@hppritcha hppritcha merged commit 113c237 into open-mpi:v2.0.x Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquyres jsquyres jsquyres approved these changes

@bosilca bosilca bosilca approved these changes

Assignees

@bosilca bosilca

Labels

bug RM approved

Projects

None yet

Milestone

v2.0.3

Development

Successfully merging this pull request may close these issues.

5 participants

@ggouaillardet @bosilca @rhc54 @jsquyres @hppritcha