osc-portals4: add support for noncontiguous datatypes #2999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements onesided operations for noncontiguous datatypes using two different algorithms. * If the result and/or origin datatype is noncontiguous and the target datatype is contiguous, then an iovec MD is created for the result and origin. The operation is performed using a single Portals4 call (unless it exceeds the max message size). * If the target datatype is noncontigous, then an algorithm similar to the one in osc-rdma is used to loop over the contiguous blocks of each datatype. The operation is performed using multiple Portals4 calls. This commit ensures that individual operations do not exceed the max atomic size or the max message size supported by the device. Signed-off-by: Todd Kordenbrock <thkgcode@gmail.com> (cherry picked from commit 048f757)
regrant
approved these changes
Feb 16, 2017
Contributor
regrant
left a comment
regrant
left a comment
There was a problem hiding this comment.
Same as the work on master, this is approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements onesided operations for noncontiguous
datatypes using two different algorithms.
target datatype is contiguous, then an iovec MD is created for
the result and origin. The operation is performed using a
single Portals4 call (unless it exceeds the max message size).
similar to the one in osc-rdma is used to loop over the
contiguous blocks of each datatype. The operation is
performed using multiple Portals4 calls.
This commit ensures that individual operations do not exceed the
max atomic size or the max message size supported by the device.
Closes issue #143
(master PR #2986)
@regrant - Please review