v2.0.3: compiler warning fixes #3187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use the "non-null" arg attribute stuff anywhere else, and we don't use it on master. So go ahead and remove it here, thereby fixing a compiler warning (that we are redundantly checking the args for NULL in the definition of the routine). Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Don't define the madvise intercept functions since we're not currently intercepting madvise. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit b51c4e2)
Remove unused variable. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Remove unused variables and unused label. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Remove now-unused code and unused variable. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Remove unused variable. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Add missing "const" qualifiers to some arguments. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
hppritcha
approved these changes
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of compiler warning fixes, most of which are unique to the v2.0.x branch.
At least one was in common with master (the memory/patcher fix), which was cherry picked from a commit in #3185.
I did not check to see if there were commits on master that fixed the other warnings; I just fixed them directly here on v2.0.x (it did not seem worth the spelunking effort).
@hppritcha Please review.