v2.x: opal: add support for s390 and s390x architectures #3449
Conversation
Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin@suse.com>
|
Can one of the admins verify this patch? |
|
@nmorey The intent for this PR is to enable Vader's CMA support to compile on S390[X] platforms, is that correct? Note that we usually commit such fixes to @bosilca @hjelmn Can you have a quick look? Looks fairly straightforward. |
|
Cross-reference: #3443 |
|
@jsquyres Yes. I had to fix 2.1.0 build for SUSE so I sent the patch as is but I can probably port it to master. |
|
@nmorey Excellent; thanks! |
jsquyres
changed the title
|
@jsquyres, we shouldn't merge this patch to 2.x until it's 1) in master and 2) there's a PR to 3.x as well... |
|
@bwbarrett I'll do one for 3.x once master gets accepted then :) |
|
@nmorey: yes, the usual path for PRs in Open MPI is master then to the branches. @jsquyres, @hppritcha, and I are currently trying to make sure that we don't accidentally ship something in 2.1, but then not in 3.0, so the comment was as much for us as anyone :). |
|
#3454 was just merged to master; it is a slightly updated version of this PR (i.e., added a comment). |
|
@hppritcha Do you have an opinion on whether this should go to v2.1.1 or v2.1.2? |
|
Corresponding master PR: #3454 |
|
Per discussion with @bwbarrett, this will go into v3.x, so let's go ahead and take this in v2.x. |
4 participants
Signed-off-by: Nicolas Morey-Chaisemartin NMoreyChaisemartin@suse.com